-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: copy container images #4209
Conversation
…actor-tag-generation
|
||
ciPipeline, err := handler.ciPipelineRepository.GetCiPipelineByArtifactId(artifactId) | ||
var externalCiPipeline *pipelineConfig.ExternalCiPipeline | ||
ciArtifact, err := handler.ciArtifactRepository.Get(artifactId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all this below code can be part of service
handler.Logger.Errorw("Error in fetching ci artifact by ci artifact id", "err", err) | ||
return externalCi, ciPipelineId, appId, err | ||
} | ||
if ciArtifact.DataSource == repository.POST_CI { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment down all the probable DataSource in model
@@ -79,7 +79,8 @@ func (r ApplicationRouterImpl) initApplicationRouter(router *mux.Router) { | |||
router.Path("/{applicationName}/managed-resources"). | |||
Methods("GET"). | |||
HandlerFunc(r.handler.ManagedResources) | |||
router.Path("/{name}/rollback"). | |||
router.Path("/{name}" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applicationName ?
} | ||
|
||
commonQuery = fmt.Sprintf(commonQuery, listingFilterOptions.PipelineId, listingFilterOptions.StageType, listingFilterOptions.ParentId, listingFilterOptions.ParentStageType, listingFilterOptions.SearchString) | ||
commonQuery := " from ci_artifact LEFT JOIN cd_workflow ON ci_artifact.id = cd_workflow.ci_artifact_id" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
describe in comment what results we expects from this query
" AND ((cd_workflow.pipeline_id= %v and cd_workflow_runner.workflow_type = '%v' ) OR (cd_workflow.pipeline_id = %v AND cd_workflow_runner.workflow_type = '%v' AND cd_workflow_runner.status IN ('Healthy','Succeeded') )))" + | ||
" OR (ci_artifact.component_id = %v and ci_artifact.data_source= '%v' ))" + | ||
" AND (ci_artifact.image LIKE '%v' )" | ||
//commonQuery := " FROM cd_workflow_runner " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented code
pkg/pipeline/PipelineBuilder.go
Outdated
@@ -250,7 +250,7 @@ type ConfigMapSecretsResponse struct { | |||
} | |||
|
|||
func parseMaterialInfo(materialInfo json.RawMessage, source string) (json.RawMessage, error) { | |||
if source != "GOCD" && source != "CI-RUNNER" && source != "EXTERNAL" { | |||
if source != "GOCD" && source != "CI-RUNNER" && source != "EXTERNAL" && source != "pre_cd" && source != "post_cd" && source != "post_ci" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use constants
destinationRegistryRepoDetails := strings.Split(destinationInfo, "\n") | ||
for _, detail := range destinationRegistryRepoDetails { | ||
registryRepoSplit := strings.Split(detail, "|") | ||
registryName := strings.Trim(registryRepoSplit[0], " ") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use EmptyString Constaint
scripts/sql/190_custom_tag.down.sql
Outdated
@@ -0,0 +1,7 @@ | |||
ALTER TABLE custom_tag DROP COLUMN enabled; | |||
ALTER TABLE ci_artifact DROP COLUMN credentials_source_type ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use single seq file for the release
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Description
Fixes #4259
#3521
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?