Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Revamped Security Feature Doc #4349

Merged
merged 8 commits into from
Feb 5, 2024
Merged

doc: Revamped Security Feature Doc #4349

merged 8 commits into from
Feb 5, 2024

Conversation

ashokdevtron
Copy link
Contributor

  • Replaced a few snapshots
  • Added borders to all the snapshots
  • Included Block if fix is available option
  • Added hyperlinks for easy navigation
  • Reformatted the text
  • Added figure captions

@ashokdevtron ashokdevtron self-assigned this Dec 5, 2023
abhibhaw
abhibhaw requested changes Dec 5, 2023
View reviewed changes
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing RBAC

@ashokdevtron
Copy link
Contributor Author

Missing RBAC

Added RBAC

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

abhibhaw
abhibhaw previously approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

uxarya-d
uxarya-d requested changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@uxarya-d uxarya-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added review comments.

docs/user-guide/security-features.md Outdated Show resolved Hide resolved
docs/user-guide/security-features.md Outdated Show resolved Hide resolved
docs/user-guide/security-features.md Outdated Show resolved Hide resolved
docs/user-guide/security-features.md Outdated Show resolved Hide resolved
docs/user-guide/security-features.md Outdated Show resolved Hide resolved
docs/user-guide/security-features.md Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ashokdevtron ashokdevtron merged commit d123afc into main Feb 5, 2024
5 checks passed
@ashokdevtron ashokdevtron deleted the revamped-securefeat branch February 5, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uxarya-d uxarya-d uxarya-d approved these changes

@abhibhaw abhibhaw abhibhaw left review comments

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

Assignees

@ashokdevtron ashokdevtron

Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashokdevtron @abhibhaw @uxarya-d