Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Inconsistent behaviour on deploying application from application group v/s devtron cli tool after changing deploymentType #4353

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

ShashwatDadhich
Copy link
Contributor

@ShashwatDadhich ShashwatDadhich commented Dec 5, 2023

Description

📜 Description
After changing deploymentType from argoCD to Helm or vice-versa and then triggering deployment from application groups breaks app details page, Build and Deploy page and workflow editor page for that particular application.

👟 Reproduction steps
Change the Application's Deploy Type from helm to argocd or vice-versa using devtctl tool.
Deploy the same application using application groups.
Go to the app details page, Build and Deploy page, or workflow editor page. All of them would be broken.

Fixes #4353

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ShashwatDadhich ShashwatDadhich changed the title fix fix:Inconsistent behaviour on deploying application from application group v/s devtron cli tool after changing deploymentType Dec 5, 2023
@ShashwatDadhich ShashwatDadhich changed the title fix:Inconsistent behaviour on deploying application from application group v/s devtron cli tool after changing deploymentType fix:I nconsistent behaviour on deploying application from application group v/s devtron cli tool after changing deploymentType Dec 5, 2023
@ShashwatDadhich ShashwatDadhich changed the title fix:I nconsistent behaviour on deploying application from application group v/s devtron cli tool after changing deploymentType fix: Inconsistent behaviour on deploying application from application group v/s devtron cli tool after changing deploymentType Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants