Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: App Store refactoring v2 #4580

Merged
merged 84 commits into from
Feb 5, 2024

Conversation

Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Jan 22, 2024

Description

Code Refactoring and Restructuring for App Store Deployment services

Fixes #

How Has This Been Tested?

  • Sanity of AppStore services

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


kartik-579 and others added 30 commits January 11, 2024 12:59
* removed unsued jira integration

* removed test-suite-code

* db migration conf removal

* chore: removed unused injection

* chore: removed dead code

* added: migration script

---------

Co-authored-by: Ash-exp <asutosh2000ad@gmail.com>
* moved chart-group in seperate code

* removed unused dependency

* removed dead code

* extracted resource tree

* moved notes

* resource movement

* removed unused code

* removed unused dependency

* commit methods

* extracted status update

* chore: clean up unused dead code

* updated: EA mode docker file

* updated: migration number

---------

Co-authored-by: Ash-exp <asutosh2000ad@gmail.com>
Base automatically changed from chore-refactoring-v1 to main January 24, 2024 11:36
kartik-579 and others added 6 commits January 31, 2024 11:02
… for CLI (#3708)

* new api added for getting ciPipelineDetails by only ciPipelineId

* appName field added in ci-pipeline struct

* appType field added in ci-pipeline struct

* code review comments incorporation
@Ash-exp Ash-exp changed the base branch from main to refactoring-template-gitOps-appStore February 5, 2024 06:53
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

128 New issues
0 Security Hotspots
No data about Coverage
0.7% Duplication on New Code

See analysis details on SonarCloud

@Ash-exp Ash-exp merged commit f62c263 into refactoring-template-gitOps-appStore Feb 5, 2024
3 checks passed
@Ash-exp Ash-exp deleted the chore-refactoring-v2 branch February 5, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants