Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Add option to disable colors #22

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Conversation

AP2008
Copy link
Contributor

@AP2008 AP2008 commented Oct 22, 2021

Fixes #9 .
I added a --no-color to disable all colors.
2021-10-22-104245_1552x380_scrot

@AP2008 AP2008 changed the title Fix #9 Fix: Add option to disable colors Oct 22, 2021
@arushi09-hub
Copy link

Hi There,
We thank you for your valuable contributions. Please follow the steps below for the Giveaways Entry -

  1. Once the PR is raised you can join the discord community for the upcoming updates.
  2. After joining the community, send your PR link on the #contrib channel with the tag @Hacktoberfest.
  3. We will evaluate the PR and once it is accepted , we will send you the swags.

@AP2008
Copy link
Contributor Author

AP2008 commented Oct 22, 2021

@arushi09-hub Done!

@AP2008 AP2008 changed the title Fix: Add option to disable colors FIX: Add option to disable colors Oct 22, 2021
@pghildiyal
Copy link
Member

I will check it out and revert back on it.. give me a day or two

@AP2008
Copy link
Contributor Author

AP2008 commented Oct 22, 2021

Sure!

@AP2008
Copy link
Contributor Author

AP2008 commented Oct 26, 2021

@pghildiyal Does it work ?

@AP2008 AP2008 closed this Oct 26, 2021
@AP2008 AP2008 reopened this Oct 26, 2021
@Abhinav-26
Copy link
Member

@pghildiyal Does it work ?

Hey @AP2008, we have checked-out the changes and its working really great. Here's a few things which can be done -

  • Removed API Version text should also be in red
  • Please add --no-color flag in Argument section of README

@AP2008
Copy link
Contributor Author

AP2008 commented Oct 27, 2021

@pghildiyal Does it work ?

Hey @AP2008, we have checked-out the changes and its working really great. Here's a few things which can be done -

  • Removed API Version text should also be in red
  • Please add --no-color flag in Argument section of README

@Abhinav-26 I'll add that in the README. Can you share a screenshot of the current behaviour of the Removed API Version text ?

@Abhinav-26
Copy link
Member

Abhinav-26 commented Oct 27, 2021

@pghildiyal Does it work ?

Hey @AP2008, we have checked-out the changes and its working really great. Here's a few things which can be done -

  • Removed API Version text should also be in red
  • Please add --no-color flag in Argument section of README

@Abhinav-26 I'll add that in the README. Can you share a screenshot of the current behaviour of the Removed API Version text ?

Sure @AP2008 , Here's how it looks as of now when we use --no-color flag, but you can checkout the current behaviour of Removed API Version text from the README and also I have attached the image below ~

Screenshot 2021-10-27 at 3 18 09 PM

Screenshot 2021-10-27 at 3 18 09 PM

@AP2008
Copy link
Contributor Author

AP2008 commented Oct 27, 2021

@pghildiyal Does it work ?

Hey @AP2008, we have checked-out the changes and its working really great. Here's a few things which can be done -

  • Removed API Version text should also be in red
  • Please add --no-color flag in Argument section of README

@Abhinav-26 I'll add that in the README. Can you share a screenshot of the current behaviour of the Removed API Version text ?

Sure @AP2008 , Here's how it looks as of now ~

Screenshot 2021-10-27 at 3 18 09 PM

@Abhinav-26 Do you want the Removed API Version text to be red even in nocolor mode ?

@Abhinav-26
Copy link
Member

@pghildiyal Does it work ?

Hey @AP2008, we have checked-out the changes and its working really great. Here's a few things which can be done -

  • Removed API Version text should also be in red
  • Please add --no-color flag in Argument section of README

@Abhinav-26 I'll add that in the README. Can you share a screenshot of the current behaviour of the Removed API Version text ?

Sure @AP2008 , Here's how it looks as of now ~
Screenshot 2021-10-27 at 3 18 09 PM

@Abhinav-26 Do you want the Removed API Version text to be red even in nocolor mode ?

Yes, Removed API Version text should be in red even in --no-color mode.

@AP2008
Copy link
Contributor Author

AP2008 commented Oct 29, 2021

@pghildiyal @Abhinav-26 I have commited the requested changes. Can it be merged (or do I need to make any further changes)?

@Abhinav-26 Abhinav-26 merged commit e83ded4 into devtron-labs:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color output unreadable in terminal with light background.
4 participants