Feature/truffle setup #7
Conversation
| @@ -1,7 +1,7 @@ | |||
| pragma solidity 0.6.9; | |||
|
|
|||
| // SPDX-License-Identifier: MIT | |||
| import "https://raw.githubusercontent.com/smartcontractkit/chainlink/develop/evm-contracts/src/v0.6/ChainlinkClient.sol"; | |||
| import "./Chainlink/ChainlinkClient.sol"; | |||
There was a problem hiding this comment.
Nice changes.
I will suggest that we gitignore all the chainlink files because they are dependencies which we will not be changing. Let's put them in a folder and git ignore the folder. We can add a script to fetch it in our package.json.
There was a problem hiding this comment.
chainlink contracts are already in a folder named chainlink i would say adding a .gitignore to it them is not a bad call
There was a problem hiding this comment.
You might want to check this: https://stackoverflow.com/questions/24290358/remove-a-folder-from-git-tracking
We need to remove chainlink folder from git cache
There was a problem hiding this comment.
^^ File changes should not include the chainlink contracts if everything works fine. But you might want to include instructions on how to get those files or include a script in package.json to auto get them for other users.
There was a problem hiding this comment.
Hmmmm true .... you have any reference for a script that will auto get these from package.json
There was a problem hiding this comment.
I wrote a mocha test for EscrowSalt, should I create a new PR for it or just commit it into feature/truffle-setup?
There was a problem hiding this comment.
@Jaylukmann , I new PR will be better
There was a problem hiding this comment.
Please, let's not push changes to another person's PR except if the person is not around and we can't wait for them to come back.
truffle setup for Dexcrows contracts