postgres: fix tx leak on serialization failure #1363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this bug was actually the only reason the concurrency tests passed! instead, the tests are now updated to eventually be serializable after 10 attempts, and they assert that it took 10 attempts to work, effectively testing the retry logic. this is all running on the theory that, there shouldn't be any cases that are truly never serializable - any and all of those are bugs to be fixed. the tests forced an impossible situation, which is not realistic when compared to client-initiated API calls.
|
Hmm, the concurrency tests failed on Travis; looks like the other storage providers would also need retry logic baked in too. |
|
Please check my PR #1370 for different solution as serializable isolation level is overkill for an application like dex. |
|
closing this in favor of #1370 - we're tidying up our own branches in prep for submitting PRs and it doesn't seem worth maintaining this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1355 which was caused by #1342
also related: #1356 and #1357