server,cmd: Add flag for disabling registation #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For situations where admins add users.
| @@ -44,6 +44,8 @@ func main() { | |||
| emailFrom := fs.String("email-from", "no-reply@coreos.com", "emails sent from dex will come from this address") | |||
| emailConfig := fs.String("email-cfg", "./static/fixtures/emailer.json", "configures emailer.") | |||
|
|
|||
| enableRegistration := fs.Bool("enable-registration", true, "Allows users to self-register") | |||
There was a problem hiding this comment.
Should this default to true? While we might break existing installs if it defaults to false, it seems safer to have open registration be the explicit choice.
There was a problem hiding this comment.
I had the same thought process. yeah, you're probably right.
|
Looks great! |
|
Thanks joe, PTAL when you can! |
|
LGTM |
bobbyrullo
added a commit
that referenced
this pull request
Oct 1, 2015
server,cmd: Add flag for disabling registation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For situations where admins add users.