Support setting the prompt type for the Microsoft connector #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erica Taylor <ricky@wellplayed.games>
ricky26
force-pushed
the
microsoft-prompt-type
branch
from
726879f
to
ba47aab
Compare
sagikazarmark
approved these changes
Apr 24, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Erica Taylor ricky@wellplayed.games
Overview
This PR adds a
promptTypefield to the configuration of the Microsoft connector.Closes #1911.
What this PR does / why we need it
This allows users of Dex to specify which kind of prompt the Microsoft connector should display. Previously this used the default value which didn't prompt unless the user was signed out of Microsoft.
Special notes for your reviewer
Does this PR introduce a user-facing change?