Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flag for lowercase email casting in GitHub connector #2579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomwatkin
Copy link

Signed-off-by: Thom Watkin twatkin@provectus.com

Overview

Adds functionality from #1888 to the GitHub provider.

Follows for similar reasons - we don't always know what the casing of a given user's email will be, especially given that most email clients treat the value as case-insensitive.

What this PR does / why we need it

Closes #2578

Adds the ability for us to cast all user emails returned from GitHub to lowercase using the flag emailToLowercase

Special notes for your reviewer

N/A

Does this PR introduce a user-facing change?

Allows admins to optionally enable the `emailToLowercase` flag, which will cast all emails returned from Dex to lowercase. 

Disabled by default. 

Useful when you're unable to verify or match the casing of a user's email. 

Signed-off-by: Thom Watkin <twatkin@provectus.com>
Copy link

@ms443 ms443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for GitHub connector to cast user email to lowercase
2 participants