use log/slog for structured logging #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you @seankhliao, I really appreciate you tackling this.
I'm mostly satisfied with how things look. I made a few comments, curious what you think.
seankhliao
force-pushed
the
slog
branch
3 times, most recently
from
a5a5908
to
45e201f
Compare
nabokihms
reviewed
May 13, 2024
nabokihms
approved these changes
May 31, 2024
Signed-off-by: Sean Liao <sean+git@liao.dev>
|
i rebased to resolve a conflict with new additions to the google connector |
|
@sagikazarmark from my point of view, looks good enough to be merged. Anything else from your side? |
sagikazarmark
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Switches pkg/log and logrus for the standard library's slog logger.
What this PR does / why we need it
This is more or less a mechanical replacement of the internal
log.Loggerinterface andlogruslogger with the standard library's slog.This appears to be the general community consensus on a standard logging interface, where slog.Logger is used as the common interface, and implementations can switch out the
slog.Handlerif necessary.Connectors have their type and id added as attributes.
Log lines are lowercased for consistency.
Closes #2020
Special notes for your reviewer
If dex is used as a library, this will be a breaking change.
Log line output will be different from before.