Add ability to override JWKS URL for OIDC connector #3527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
nabokihms
force-pushed
the
override-jwks-url
branch
from
1867ffe
to
2f98275
Compare
sohgaura
reviewed
May 14, 2024
| @@ -107,6 +107,9 @@ type ProviderDiscoveryOverrides struct { | |||
| // AuthURL provides a way to user overwrite the Auth URL | |||
| // from the .well-known/openid-configuration authorization_endpoint | |||
| AuthURL string `json:"authURL"` | |||
| // JWKSURL provides a way to user overwrite the JWKS URL | |||
| // from the .well-known/openid-configuration jwks_uri | |||
| JWKSURL string `json:"jwksURL"` | |||
| } | |||
|
|
|||
| func (o *ProviderDiscoveryOverrides) Empty() bool { | |||
There was a problem hiding this comment.
Line 113 in 347beba
Pls do a check for JWKSURL as well, current condition only checks authurl and tokenurl to override values. This will not work if only JWKSURL is passed.
Add required changes to oidc_test.go for consistency.
|
Closing in favour of #3543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add an option to override discovered JWKS endpoint for OIDC connector
What this PR does / why we need it
closes #3519
Special notes for your reviewer
The test to check the change would have been cumbersome if we had implemented it (because the library doesn't expose the JWKS URL).