feat: also allow localhost equivalent IP addresses #3778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only checking for "localhost", also validate through net.ParseIP + IsLoopback whether the host is numerically localhost Signed-off-by: Daniel Sonck <daniel@sonck.nl>
dsonck92
force-pushed
the
also-allow-numeric-localhost
branch
from
0386dbd
to
af7599e
Compare
nabokihms
approved these changes
Oct 7, 2024
|
Great improvement! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Instead of only checking for "localhost", also validate through
net.ParseIP+IsLoopbackwhether the host is numerically localhostWhat this PR does / why we need it
Currently,
localhostis already used as a special case that allows any port and http scheme if no particular redirectURIs are configured. When integrating with ownClouds desktop client, it actually sends an arbitraryhttp://127.0.0.1:xyzredirect uri. Considering that the go standard library already has the functionality to check if a given IP is a loopback address, we can extend the== "localhost"with also a check forIsLoopback()which should allow the ownCloud desktop client to be accepted.Special notes for your reviewer