-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add gRPC definition for version endpoint. #683
Conversation
// Dex represents the dex gRPC service. | ||
service Dex { | ||
// CreateClient attempts to create the client. | ||
// CreateClient creates the client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: creates a client.
Small note: .proto requires you to decalre it as int32 or int64, there is no default int type. Chose int32 for now. let me know if you want to change it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits
message VersionReq {} | ||
|
||
// VersionResp returns version info. | ||
message VersionResp { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can probably just hold the Version
fields directly. We don't need the Version
message.
message Version { | ||
// Semantic version of the server. | ||
string server = 1; | ||
// Numeric version of the API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please expand this comment to reflect the comment in server/api.go
. Maybe even just copy it here.
We expect outside users to read this file, not the Go code.
rpc DeletePassword(DeletePasswordReq) returns (DeletePasswordResp) {}; | ||
// GetVersion gets the version info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe GetVersion
returns version information of the server.
1d5426d
to
ef6a4fd
Compare
int32 sounds fine. Doubt we'll run out of space. |
ef6a4fd
to
de4e23a
Compare
lgtm |
Closes #659.