Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a tyop in the storage documentation #688

Merged
merged 1 commit into from
Nov 15, 2016
Merged

Conversation

SEJeff
Copy link
Contributor

@SEJeff SEJeff commented Nov 15, 2016

Found while reading the docs

@ericchiang
Copy link
Contributor

README -> Documentation/storage.md?

@SEJeff
Copy link
Contributor Author

SEJeff commented Nov 15, 2016

@ericchiang better? ^^

@SEJeff SEJeff changed the title Fix a tyop in the README Fix a tyop in the storage documentation Nov 15, 2016
@ericchiang
Copy link
Contributor

Typo in your commit message. Also we generally prefix the commit message with the directory. So it would be

Documentation: fix a typo in the storage documentation

That okay?

@SEJeff
Copy link
Contributor Author

SEJeff commented Nov 15, 2016

@ericchiang yes, the commit message is misspelled on purpose. It was sarcasm. I'll fix it since you don't appreciate the humour. Just a moment please.

@SEJeff
Copy link
Contributor Author

SEJeff commented Nov 15, 2016

Hopefully that looks better. I'll try to do a better job the next time I contribute to CoreOS Inc. projects.

@ericchiang
Copy link
Contributor

Ah sorry. Those kinds of jokes are hard over the internet. Thanks for the fix!

@ericchiang ericchiang merged commit 91c88c8 into dexidp:master Nov 15, 2016
@SEJeff SEJeff deleted the patch-1 branch November 15, 2016 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants