connector/ldap: Always set tls.Config.ServerName, to support LDAP ser… #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vers with public CA certs.
|
It's really weird that we have to set this in the first place, this should be inferred as part of the dial call[0]. It looks like the LDAP client actually does its own handshake instead of using tls.Dial[1]. Will merge this and open an issue on the LDAP client. [0] https://github.com/golang/go/blob/go1.7.3/src/crypto/tls/tls.go#L134-L141 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vers with public CA certs.
It seems if you're going to use TLS at all, you always want to set ServerName. This way, you can talk to a remote LDAPS server and use the local host's default CA certificates, with no need to specify the rootCA ldap config.