Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow getAttr to return DN #698

Merged
merged 1 commit into from
Nov 18, 2016
Merged

Conversation

Calpicow
Copy link
Contributor

@Calpicow Calpicow commented Nov 18, 2016

Specify "DN" as attribute name to return, but will only work if not present in ldap.Entry.Attributes
Use when full DN is stored in groupSearch's userAttr

Related to #536

@ericchiang
Copy link
Contributor

Seems reasonable, but most LDAP implementations we've dealt with actually embed the DN in the entry. What tech are you trying to query that doesn't?

Also I'd be helpful to include a note in the LDAP documentation for this behavior.

@Calpicow
Copy link
Contributor Author

Calpicow commented Nov 18, 2016

I'm not too familiar with LDAP implementations elsewhere, but the one we have doesn't contain the DN path as any other attribute.

I'll add a note in the documentation.

@ericchiang
Copy link
Contributor

Okay np. As part of this PR can you add a comment to the following two locations to document this behavior?

Specify "DN" as attribute name to return, but will only work if not present in ldap.Entry.Attributes
Use when full DN is stored in groupSearch's userAttr
@ericchiang
Copy link
Contributor

lgtm

@ericchiang ericchiang merged commit a7db295 into dexidp:master Nov 18, 2016
@Calpicow Calpicow deleted the groupsearch_by_dn branch December 7, 2016 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants