connector: add RefreshConnector interface #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchiang
force-pushed
the
connector-interface-cleanup
branch
from
9dd281c
to
2f3f12d
Compare
ericchiang
changed the title
ericchiang
force-pushed
the
connector-interface-cleanup
branch
3 times, most recently
from
87a4f9e
to
f1e45b0
Compare
|
Tests added. Manually tested LDAP and GitHub. cc @rithujohn191 ready for review |
|
|
||
| // If a user has updated their username, that will be reflected in the | ||
| // refreshed token. | ||
| identity.Username = p.Username |
There was a problem hiding this comment.
is the identity.Username the only field that can be updated?
There was a problem hiding this comment.
no, this is a bug, thanks!
There was a problem hiding this comment.
Actually I think that practically this is the only field that could be updated. Email can't be because it's used as the ID and this doesn't deal with groups. Will expand the comment.
| Email string `json:"email"` | ||
| } | ||
|
|
||
| func (c *githubConnector) user(ctx context.Context, client *http.Client) (user, error) { |
There was a problem hiding this comment.
Might be helpful to add some comments to describe user and teams functions
ericchiang
force-pushed
the
connector-interface-cleanup
branch
from
f1e45b0
to
6980920
Compare
|
comments addressed. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress to add a RefreshConnector interface so refresh token requests query the upstream identity provider before returning.
Lots of testing needed.
Closes #693
Updates #678