Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: support POSTing to authorization endpoint #792

Merged
merged 1 commit into from Jan 27, 2017
Merged

server: support POSTing to authorization endpoint #792

merged 1 commit into from Jan 27, 2017

Conversation

ericchiang
Copy link
Contributor

cc @rithujohn191 @marians

Fixes #791

Probably a cherry pick candidate.

rithujohn191
rithujohn191 approved these changes Jan 27, 2017
View reviewed changes
Copy link
Contributor

@rithujohn191 rithujohn191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ericchiang ericchiang merged commit 0dcf1bc into dexidp:master Jan 27, 2017
@ericchiang ericchiang deleted the auth-endpoint-post branch January 27, 2017 21:36
@marians
Copy link
Contributor

marians commented Mar 2, 2017

Cool that you worked on this!

Question: Did you remove the support for GET requests? It appears so, but I can't read that safely from the code change. I'm asking because both GET and POST MUST be supported.

@ericchiang
Copy link
Contributor Author

@marians no. We didn't remove the support for GET. ParseForm puts all URL query and POST form data into http.Request.Form.[0] We have test coverage for GET URL queries too.[1]

[0] https://golang.org/pkg/net/http/#Request.ParseForm
[1] https://github.com/ericchiang/dex/blob/8541184afb79448d2f4f8be785dc7753a360557e/server/oauth2_test.go#L169

@marians
Copy link
Contributor

marians commented Mar 2, 2017

@ericchiang Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithujohn191 rithujohn191 rithujohn191 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericchiang @marians @rithujohn191