-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a versionintroduced
variable to the frontmatter of connector pages
#93
Conversation
Deploy preview:
|
…le.html to show it. Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
7ea46d6
to
22761fe
Compare
last force-push uses a sane |
I have a question. Do we want to change the version in this field if we changed the config of the connector, e.g., added a new option? |
Thanks @nate-double-u I had the following in mind:
I think that would answer your question @nabokihms Also, I don't think we have to add it to every page/connector. |
So something that could be added (almost like a label) next to a line of copy or a paragraph? |
Either that, or something like this on the Symfony website: https://symfony.com/doc/current/routing.html |
I understand now. On their site, the following
I like that, but it's a bit more involved. I think I can piggyback off the |
Yeah, something like that would be great. I think we can create custom shortcodes/snippets in Hugo. For example, a custom version admonition could accept a version as a parameter and use that internally to compare it to the current version in the config file. I don't know if Hugo templates has a semver function for that though. This is still very much just an idea, so if there are other, better patterns out there, I'm all ears. |
@nate-double-u I started something very simple in #132 Do you think you could help finishing it (adding some style, etc) |
Hi--I'm on vacation this week, but can take a look when I'm back 🙂 |
I'm going to close this PR. Now we've moved to Docsy we'd need a different implementation I think. |
Adding
versionintroduced
variable to frontmatter of connector pages, and updating thesingle.html
file to display a "Since v0.0.0" message if it is set.I don't know when each connector was introduced, so @sagikazarmark, @nabokihms please suggest one using the
```suggest
notation for each of the files updated.closes: #92