Fix Table.bulkGet return typing to include undefined #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the typing for Table.bulkGet() to indicate the returned array may include undefined items. (Per the [bulkGet docs][], "For those keys that do not exist in the database, undefined will be returned in their place.") [bulkGet docs]: https://dexie.org/docs/Table/Table.bulkGet()
|
(Not really sure how to test this, short of pulling in dtslint or tsd. But I did add a |
|
(Build passed; not sure why GH checks aren't updating: https://travis-ci.org/github/dfahlander/Dexie.js/builds/715647161) |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the typing for Table.bulkGet() to indicate
the returned array may include undefined items.
(Per the bulkGet docs, "For those keys that do not
exist in the database, undefined will be returned in their
place.")