Verify schema on open #1108
Merged
Verify schema on open #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason 1: There are scenarios when this failure would have been working in production. For example when a declared index is never used. We cannot start destroying dexie user's apps when they upgrade. Reason 2: If we throw, there is a great chance people don't catch and don't understand or see the error. If we warn, people will always see it in the console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn on console in the case that the schema is altered without a version increment.
Don't fail, because this could destroy prod environments that works despite a faulty schema.
Warn unconditionally no matter the value of Dexie.debug. This is an important warning and it can be easily fixed by the user - just increment version number passed to db.version(...).