Implemented banners and banner patterns #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaPigGuy
requested changes
Jul 23, 2022
DaPigGuy
approved these changes
Jul 24, 2022
abimek
suggested changes
Jul 25, 2022
89 tasks
# Conflicts: # server/item/register.go
Sandertv
requested changes
Aug 1, 2022
server/item/banner_pattern.go
Outdated
| type BannerPattern struct { | ||
| // Pattern represents the type of banner pattern. These types do not include all patterns that can be applied to a | ||
| // banner. | ||
| Pattern BannerPatternType |
There was a problem hiding this comment.
Would name this field Type probably.
server/block/banner_pattern_layer.go
Outdated
|
|
||
| // BannerPatternLayer is a wrapper over BannerPatternType with a colour property. | ||
| type BannerPatternLayer struct { | ||
| BannerPatternType |
There was a problem hiding this comment.
Would probably not embed BannerPatternType in here, but have a Type name.
Sandertv
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.