Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removes a circular dependency on index for canisterStatus #688

Merged
merged 2 commits into from
Feb 14, 2023
Merged

chore: removes a circular dependency on index for canisterStatus #688

merged 2 commits into from
Feb 14, 2023

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Feb 14, 2023 •
edited
Loading

Description

chore: removes a circular dependency on index for canisterStatus

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner February 14, 2023 19:04
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/agent 88.8 KB (-1.24% 🔽)
@dfinity/candid 15.46 KB (0%)
@dfinity/principal 6.77 KB (0%)
@dfinity/auth-client 94.86 KB (-0.64% 🔽)
@dfinity/assets 91.55 KB (-0.58% 🔽)
@dfinity/identity 91.94 KB (-0.45% 🔽)
@dfinity/identity-secp256k1 230.09 KB (+0.04% 🔺)

@krpeacock krpeacock merged commit 247ccd4 into main Feb 14, 2023
@krpeacock krpeacock deleted the kyle/canisterstatus-circular-import branch February 14, 2023 21:27
@dskloetd dskloetd mentioned this pull request Mar 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfx-json dfx-json dfx-json approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krpeacock @dfx-json