Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed sync_and_stop to load in mem cache #152

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Fixed sync_and_stop to load in mem cache #152

merged 1 commit into from
Feb 2, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented Feb 2, 2024 •
edited
Loading

The following provides a wrapper around RunningDefinition used for testing.
It fixes previous sync to also load the in-mem cache

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner February 2, 2024 16:33
NikolaMilosa
NikolaMilosa approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@NikolaMilosa NikolaMilosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets see if this helps! Thanks

@pietrodimarco-dfinity pietrodimarco-dfinity added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit 132713c Feb 2, 2024
3 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the fix-one-shot-sync-and-dump branch February 2, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaMilosa NikolaMilosa NikolaMilosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pietrodimarco-dfinity @NikolaMilosa