Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSD visual diff #154

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Add MSD visual diff #154

merged 3 commits into from
Feb 5, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented Feb 2, 2024 •
edited
Loading

  • Added workflow to comment with a git diff main vs pr if something changes in the targets.

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner February 2, 2024 18:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

MSD Diff

  • targets.json

targets.json

--- a/home/runner/main-targets/targets.json
+++ b/home/runner/branch-targets/targets.json
@@ -4,7 +4,7 @@
       "http://[2a01:138:900a:0:6801:b5ff:fe42:bc61]:9090/"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "kxo2a-3yb52-wtj6i-qha3d-eipxa-qemke-ij4sq-h3sbz-budjc-rw2bj-5qe",
       "ic_subnet": "4ecnw-byqwz-dtgss-ua2mh-pfvs7-c3lct-gtf4e-hnu75-j7eek-iifqm-sqe",
       "job": "replica"
@@ -15,7 +15,7 @@
       "http://[2a01:138:900a:0:6801:b5ff:fe42:bc61]:9091/"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "kxo2a-3yb52-wtj6i-qha3d-eipxa-qemke-ij4sq-h3sbz-budjc-rw2bj-5qe",
       "ic_subnet": "4ecnw-byqwz-dtgss-ua2mh-pfvs7-c3lct-gtf4e-hnu75-j7eek-iifqm-sqe",
       "job": "orchestrator"
@@ -26,7 +26,7 @@
       "https://[2a01:138:900a:0:6801:b5ff:fe42:bc61]:9100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "kxo2a-3yb52-wtj6i-qha3d-eipxa-qemke-ij4sq-h3sbz-budjc-rw2bj-5qe",
       "ic_subnet": "4ecnw-byqwz-dtgss-ua2mh-pfvs7-c3lct-gtf4e-hnu75-j7eek-iifqm-sqe",
       "job": "node_exporter"
@@ -37,7 +37,7 @@
       "https://[2a01:138:900a:0:6800:b5ff:fe42:bc61]:9100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "kxo2a-3yb52-wtj6i-qha3d-eipxa-qemke-ij4sq-h3sbz-budjc-rw2bj-5qe",
       "ic_subnet": "4ecnw-byqwz-dtgss-ua2mh-pfvs7-c3lct-gtf4e-hnu75-j7eek-iifqm-sqe",
       "job": "host_node_exporter"
@@ -48,7 +48,7 @@
       "https://[2a01:138:900a:0:6800:b5ff:fe42:bc61]:19100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "kxo2a-3yb52-wtj6i-qha3d-eipxa-qemke-ij4sq-h3sbz-budjc-rw2bj-5qe",
       "ic_subnet": "4ecnw-byqwz-dtgss-ua2mh-pfvs7-c3lct-gtf4e-hnu75-j7eek-iifqm-sqe",
       "job": "host_metrics_proxy"
@@ -59,7 +59,7 @@
       "https://[2a01:138:900a:0:6801:b5ff:fe42:bc61]:19100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "kxo2a-3yb52-wtj6i-qha3d-eipxa-qemke-ij4sq-h3sbz-budjc-rw2bj-5qe",
       "ic_subnet": "4ecnw-byqwz-dtgss-ua2mh-pfvs7-c3lct-gtf4e-hnu75-j7eek-iifqm-sqe",
       "job": "guest_metrics_proxy"
@@ -70,7 +70,7 @@
       "http://[2401:3f00:1000:24:6801:eff:feec:434a]:9090/"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "nywty-nyc4x-prkyg-cy6ud-u2mxp-aizjx-ausls-vkn32-melzf-3f74u-aqe",
       "ic_subnet": "io67a-2jmkw-zup3h-snbwi-g6a5n-rm5dn-b6png-lvdpl-nqnto-yih6l-gqe",
       "job": "replica"
@@ -81,7 +81,7 @@
       "http://[2401:3f00:1000:24:6801:eff:feec:434a]:9091/"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "nywty-nyc4x-prkyg-cy6ud-u2mxp-aizjx-ausls-vkn32-melzf-3f74u-aqe",
       "ic_subnet": "io67a-2jmkw-zup3h-snbwi-g6a5n-rm5dn-b6png-lvdpl-nqnto-yih6l-gqe",
       "job": "orchestrator"
@@ -92,7 +92,7 @@
       "https://[2401:3f00:1000:24:6801:eff:feec:434a]:9100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "nywty-nyc4x-prkyg-cy6ud-u2mxp-aizjx-ausls-vkn32-melzf-3f74u-aqe",
       "ic_subnet": "io67a-2jmkw-zup3h-snbwi-g6a5n-rm5dn-b6png-lvdpl-nqnto-yih6l-gqe",
       "job": "node_exporter"
@@ -103,7 +103,7 @@
       "https://[2401:3f00:1000:24:6800:eff:feec:434a]:9100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "nywty-nyc4x-prkyg-cy6ud-u2mxp-aizjx-ausls-vkn32-melzf-3f74u-aqe",
       "ic_subnet": "io67a-2jmkw-zup3h-snbwi-g6a5n-rm5dn-b6png-lvdpl-nqnto-yih6l-gqe",
       "job": "host_node_exporter"
@@ -114,7 +114,7 @@
       "https://[2401:3f00:1000:24:6800:eff:feec:434a]:19100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "nywty-nyc4x-prkyg-cy6ud-u2mxp-aizjx-ausls-vkn32-melzf-3f74u-aqe",
       "ic_subnet": "io67a-2jmkw-zup3h-snbwi-g6a5n-rm5dn-b6png-lvdpl-nqnto-yih6l-gqe",
       "job": "host_metrics_proxy"
@@ -125,7 +125,7 @@
       "https://[2401:3f00:1000:24:6801:eff:feec:434a]:19100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "nywty-nyc4x-prkyg-cy6ud-u2mxp-aizjx-ausls-vkn32-melzf-3f74u-aqe",
       "ic_subnet": "io67a-2jmkw-zup3h-snbwi-g6a5n-rm5dn-b6png-lvdpl-nqnto-yih6l-gqe",
       "job": "guest_metrics_proxy"
@@ -136,7 +136,7 @@
       "http://[2001:1ab9:f002:5:6801:17ff:fe17:190f]:9090/"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "c2ewt-wic55-asi27-6eoeu-rn7bq-xjzmz-dzxg2-pxrfw-qeinw-yrj52-7ae",
       "ic_subnet": "pzp6e-ekpqk-3c5x7-2h6so-njoeq-mt45d-h3h6c-q3mxf-vpeq5-fk5o7-yae",
       "job": "replica"
@@ -147,7 +147,7 @@
       "http://[2001:1ab9:f002:5:6801:17ff:fe17:190f]:9091/"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "c2ewt-wic55-asi27-6eoeu-rn7bq-xjzmz-dzxg2-pxrfw-qeinw-yrj52-7ae",
       "ic_subnet": "pzp6e-ekpqk-3c5x7-2h6so-njoeq-mt45d-h3h6c-q3mxf-vpeq5-fk5o7-yae",
       "job": "orchestrator"
@@ -158,7 +158,7 @@
       "https://[2001:1ab9:f002:5:6801:17ff:fe17:190f]:9100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "c2ewt-wic55-asi27-6eoeu-rn7bq-xjzmz-dzxg2-pxrfw-qeinw-yrj52-7ae",
       "ic_subnet": "pzp6e-ekpqk-3c5x7-2h6so-njoeq-mt45d-h3h6c-q3mxf-vpeq5-fk5o7-yae",
       "job": "node_exporter"
@@ -169,7 +169,7 @@
       "https://[2001:1ab9:f002:5:6800:17ff:fe17:190f]:9100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "c2ewt-wic55-asi27-6eoeu-rn7bq-xjzmz-dzxg2-pxrfw-qeinw-yrj52-7ae",
       "ic_subnet": "pzp6e-ekpqk-3c5x7-2h6so-njoeq-mt45d-h3h6c-q3mxf-vpeq5-fk5o7-yae",
       "job": "host_node_exporter"
@@ -180,7 +180,7 @@
       "https://[2001:1ab9:f002:5:6800:17ff:fe17:190f]:19100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "c2ewt-wic55-asi27-6eoeu-rn7bq-xjzmz-dzxg2-pxrfw-qeinw-yrj52-7ae",
       "ic_subnet": "pzp6e-ekpqk-3c5x7-2h6so-njoeq-mt45d-h3h6c-q3mxf-vpeq5-fk5o7-yae",
       "job": "host_metrics_proxy"
@@ -191,7 +191,7 @@
       "https://[2001:1ab9:f002:5:6801:17ff:fe17:190f]:19100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "c2ewt-wic55-asi27-6eoeu-rn7bq-xjzmz-dzxg2-pxrfw-qeinw-yrj52-7ae",
       "ic_subnet": "pzp6e-ekpqk-3c5x7-2h6so-njoeq-mt45d-h3h6c-q3mxf-vpeq5-fk5o7-yae",
       "job": "guest_metrics_proxy"
@@ -202,7 +202,7 @@
       "http://[2401:3f00:1000:22:6801:aaff:fe6a:12f0]:9090/"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "ux7wu-iidyv-r5cth-tz6n5-4xryn-av37c-24lrk-ozfaq-7sjax-ohkd2-6ae",
       "ic_subnet": "2fq7c-slacv-26cgz-vzbx2-2jrcs-5edph-i5s2j-tck77-c3rlz-iobzx-mqe",
       "job": "replica"
@@ -213,7 +213,7 @@
       "http://[2401:3f00:1000:22:6801:aaff:fe6a:12f0]:9091/"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "ux7wu-iidyv-r5cth-tz6n5-4xryn-av37c-24lrk-ozfaq-7sjax-ohkd2-6ae",
       "ic_subnet": "2fq7c-slacv-26cgz-vzbx2-2jrcs-5edph-i5s2j-tck77-c3rlz-iobzx-mqe",
       "job": "orchestrator"
@@ -224,7 +224,7 @@
       "https://[2401:3f00:1000:22:6801:aaff:fe6a:12f0]:9100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "ux7wu-iidyv-r5cth-tz6n5-4xryn-av37c-24lrk-ozfaq-7sjax-ohkd2-6ae",
       "ic_subnet": "2fq7c-slacv-26cgz-vzbx2-2jrcs-5edph-i5s2j-tck77-c3rlz-iobzx-mqe",
       "job": "node_exporter"
@@ -235,7 +235,7 @@
       "https://[2401:3f00:1000:22:6800:aaff:fe6a:12f0]:9100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "ux7wu-iidyv-r5cth-tz6n5-4xryn-av37c-24lrk-ozfaq-7sjax-ohkd2-6ae",
       "ic_subnet": "2fq7c-slacv-26cgz-vzbx2-2jrcs-5edph-i5s2j-tck77-c3rlz-iobzx-mqe",
       "job": "host_node_exporter"
@@ -246,7 +246,7 @@
       "https://[2401:3f00:1000:22:6800:aaff:fe6a:12f0]:19100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "ux7wu-iidyv-r5cth-tz6n5-4xryn-av37c-24lrk-ozfaq-7sjax-ohkd2-6ae",
       "ic_subnet": "2fq7c-slacv-26cgz-vzbx2-2jrcs-5edph-i5s2j-tck77-c3rlz-iobzx-mqe",
       "job": "host_metrics_proxy"
@@ -257,7 +257,7 @@
       "https://[2401:3f00:1000:22:6801:aaff:fe6a:12f0]:19100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "ux7wu-iidyv-r5cth-tz6n5-4xryn-av37c-24lrk-ozfaq-7sjax-ohkd2-6ae",
       "ic_subnet": "2fq7c-slacv-26cgz-vzbx2-2jrcs-5edph-i5s2j-tck77-c3rlz-iobzx-mqe",
       "job": "guest_metrics_proxy"
@@ -268,7 +268,7 @@
       "http://[2001:4c08:2003:b09:6801:14ff:fe8d:5e38]:9090/"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "wvxfb-eqeex-26z4r-vefff-llfh7-vv76x-pje4o-oh57m-eklny-zcs56-wae",
       "ic_subnet": "eq6en-6jqla-fbu5s-daskr-h6hx2-376n5-iqabl-qgrng-gfqmv-n3yjr-mqe",
       "job": "replica"
@@ -279,7 +279,7 @@
       "http://[2001:4c08:2003:b09:6801:14ff:fe8d:5e38]:9091/"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "wvxfb-eqeex-26z4r-vefff-llfh7-vv76x-pje4o-oh57m-eklny-zcs56-wae",
       "ic_subnet": "eq6en-6jqla-fbu5s-daskr-h6hx2-376n5-iqabl-qgrng-gfqmv-n3yjr-mqe",
       "job": "orchestrator"
@@ -290,7 +290,7 @@
       "https://[2001:4c08:2003:b09:6801:14ff:fe8d:5e38]:9100/metrics"
     ],
     "labels": {
-      "ic": "mercury",
+      "ic-diff": "mercury",
       "ic_node": "wvxfb-eqeex-26z4r-vefff-llfh7-vv76x-pje4o-oh57m-eklny-zcs56-wae",
       "ic_subnet": "eq6en-6jqla-fbu5s-daskr-h6hx2-376n5-iqabl-qgrng-gfqmv-n3yjr-mqe",
       "job": "node_exporter"
@@ -

See the full diff from https://github.com/dfinity/dre/actions/runs/7759882632

sshtmc
sshtmc approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@sshtmc sshtmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@pietrodimarco-dfinity pietrodimarco-dfinity added this pull request to the merge queue Feb 5, 2024
Merged via the queue into main with commit 1bd79f4 Feb 5, 2024
3 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the msd-diff-comments branch February 5, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshtmc sshtmc sshtmc approved these changes

@NikolaMilosa NikolaMilosa NikolaMilosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pietrodimarco-dfinity @sshtmc @NikolaMilosa