Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI arg to skip the update of the local registry #191

Merged
merged 5 commits into from
Feb 18, 2024
Merged

Add CLI arg to skip the update of the local registry #191

merged 5 commits into from
Feb 18, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

  • Used for MSD test: Add arg --skip-update-local-registry to avoid syncing the local registry with remote registry canister (which cause flaky test)

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner February 13, 2024 10:42
sasa-tomic
sasa-tomic approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the discussions are resolved.

@pietrodimarco-dfinity pietrodimarco-dfinity added this pull request to the merge queue Feb 18, 2024
Merged via the queue into main with commit 23b7e1d Feb 18, 2024
4 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the skip-update-local-registry branch February 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasa-tomic sasa-tomic sasa-tomic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pietrodimarco-dfinity @sasa-tomic