feat(dre): Improve the summary of the subnet resize NNS proposals #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the improved summary: Changes: - arguments --add and --remove now include default values, allowing users to omit these values if not needed. -- the `id` field has an alias of `subnet-id` for improved readability. Refactor: the `execute` method now uses the `subnet_manager` to resize the subnet and proposes the subnet change using the `runner`. This makes the `resize` functionality very similar to the `replace` functionality, so more code can be shared between the two.
LittleChimera
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the improved summary:
Changes:
idfield has an alias ofsubnet-idfor improved readability.Refactor: the
executemethod now uses thesubnet_managerto resize the subnet and proposes the subnet change using therunner. This makes theresizefunctionality very similar to thereplacefunctionality, so more code can be shared between the two.