feat(dre): Improve dre registry a bit more #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a bit more filtering operator beside '=', such as '!=', '>', '<', startswith, endswith, contains, etc. - Remove the now unnecessary --incorrect-rewards command line option, replaced by: `--filter rewards_correct=false` - Add node details in the subnet list, for convenience (albeit this adds some verbosity, so if it's too verbose we can remove it in the future) - Reorder the output fields a bit, putting the list of subnets first
NikolaMilosa
approved these changes
Sep 25, 2024
|
Maybe add a couple of examples in description of the PR how to invoke it so we know what the idea was because it changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--filter rewards_correct=false