-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Photo storage example #355
Conversation
Thank you very much for this PR! I'd like to get back to this once dfinity/agent-js#603 is merged. Feel free to ping me when you think I should take another look |
Updated MR with above suggestions and fixed some bugs (replaced masonry dep with a more reliable masonry dep) |
Looking nice, thanks a lot! Any chance you can also add a very basic e2e test to alert us (me) when a dfx update breaks the example? This is a good example you could work from. It doesn't need to be anything fancy |
Also, the |
Added a workflow that checks if the project builds and deploys successfully. |
With
Is this a problem introduced by myself or something wrong with the code? |
Seems like a problem in |
Thank you for fixing it that quickly! Can confirm it work now. Thank you very much for contributing! |
Example React application that shows how to upload files to an assets canister with the
@dfinity/assets
package.Related PR dfinity/agent-js#603