build: bump google-protobuf for nns #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterpeterparker
added a commit
to dfinity/nns-dapp
that referenced
this pull request
Aug 2, 2022
# Motivation Bump to the last nightly version of `sns-js` that requires `agent-js` as a peer dependencies. # Note `nns-js` cannot be upgraded as well. It first needs PR dfinity/ic-js#162 because otherwise the `jest` test suite won't run. # Changes - bump `sns-js` nightly - add mandatory `agent-js` dependencies to dependencies - clean up `package-lock` by removing local path (`../../../ic-js/...`) added for development purpose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #143.
This will also fix the usage of the lib for testing purpose as it referenced a version of
google-protobufthat fails withjestin a NodeJS context - e.g. when running tests in NNS-dapp.Changes
google-protobuflast version