feat: decode payment code #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
1 task
…at/parse-payment-code
…at/parse-payment-code
lmuntaner
reviewed
Jun 21, 2023
lmuntaner
approved these changes
Jun 21, 2023
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Jun 22, 2023
# Motivation Extend QR code reader in transaction to extract encoded amount that way users can proceed payment in NNS dapp. # PRs - [x] dfinity/ic-js#354 # Changes - bump ic-js to use new function `decodePayment` - use function. if token does not match throw and error, if matches apply identifier and if provided amount # Tests It would need e2e test. I tried various ways to simulate the `nnsQRCode` custom event in jest test (as we have to skip the QRCode reader in such context) but, did not make it. Of course let me know if you know how.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In NNS dapp we want to support QR code that provides more information than only an address. We want to be able to read QR code that provides token and amount information as well.
That way a use can scan a QR code and proceed a payment in NNS dapp.
Changes
decodePaymentto the@dfinity/ledgerpackage