Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GIX-1928: Add governance test candid interface #426

Merged
merged 3 commits into from
Sep 27, 2023
Merged

GIX-1928: Add governance test candid interface #426

merged 3 commits into from
Sep 27, 2023

Conversation

lmuntaner
Copy link
Contributor

Motivation

To add maturity to NNS neurons with a test method "update_neuron".

In this PR, add candid files for the governance test canister.

Changes

  • Add new entry to import-candid.
  • Import the candid of governance canister and build the related files.

Tests

Not yet necessary. No functionality has been added.

@lmuntaner
Copy link
Contributor Author

@dskloetd @mstrasinskis please review

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 6.38 KB (0%)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger 2.92 KB (0%)
@dfinity/ledger-icp -19 B (0%)
@dfinity/nns 29.69 KB (0%)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 14.72 KB (0%)
@dfinity/utils 3.81 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

mstrasinskis
mstrasinskis approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lmuntaner lmuntaner enabled auto-merge (squash) September 27, 2023 07:06
@lmuntaner lmuntaner merged commit d0708a1 into main Sep 27, 2023
10 checks passed
@lmuntaner lmuntaner deleted the GIX-1928_LM_add-governance-test-candid branch September 27, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

@dskloetd dskloetd Awaiting requested review from dskloetd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @mstrasinskis