Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export blockheight types #444

Merged
merged 1 commit into from
Oct 3, 2023
Merged

feat: export blockheight types #444

merged 1 commit into from
Oct 3, 2023

Conversation

peterpeterparker
Copy link
Member

Motivation

While integrating the new lib in NNS dapp (PR) we noticed that few more types need to be exposed by @dfinity/ledger-icp.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

size-limit report 📦

Path Size
@dfinity/ckbtc 6.38 KB (0%)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger-icrc 2.92 KB (0%)
@dfinity/ledger-icp 14.17 KB (0%)
@dfinity/nns 29.41 KB (0%)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 14.86 KB (0%)
@dfinity/utils 3.81 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

lmuntaner
lmuntaner approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterpeterparker peterpeterparker merged commit 6244528 into main Oct 3, 2023
10 checks passed
@peterpeterparker peterpeterparker deleted the feat/types branch October 3, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @lmuntaner