Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ckBTC Candid #450

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Update ckBTC Candid #450

merged 2 commits into from
Oct 12, 2023

Conversation

dskloetd
Copy link
Collaborator

@dskloetd dskloetd commented Oct 11, 2023 •
edited
Loading

Motivation

We want to use the ICRC-2 flow for BTC withdrawal.
This is not available in the current Candid interface we have in ic-js.
So we update minter.did to the newest version.

Changes

  1. Pulled my IC repo to commit 8be68bc88db7332dd39a26509ddf62c564ca3415.
  2. Ran scripts/import-candid ../../ic
  3. Reverted everything outside packages/ckbtc/
  4. Ran scripts/compile-idl-js
  5. Reverted everything outside packages/ckbtc/

Tests

I installed @dinifty/ckbtc from local path in nns-dapp and manually tested receiving BTC and sending ckBTC.

Todos

  • Add entry to changelog (if necessary).
    not necessary?

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/ckbtc 6.68 KB (+4.74% 🔺)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger-icrc 2.92 KB (0%)
@dfinity/ledger-icp 14.17 KB (0%)
@dfinity/nns 33.48 KB (0%)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 14.89 KB (0%)
@dfinity/utils 3.81 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

@dskloetd dskloetd changed the title Kloet/ckbtc did Update ckBTC Candid Oct 12, 2023
peterpeterparker
peterpeterparker approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@peterpeterparker peterpeterparker mentioned this pull request Oct 12, 2023
Merged
@dskloetd dskloetd merged commit ef4a5e9 into main Oct 12, 2023
10 checks passed
@dskloetd dskloetd deleted the kloet/ckbtc-did branch October 12, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dskloetd @peterpeterparker