Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update outdated nns-js README #458

Merged
merged 4 commits into from
Nov 6, 2023
Merged

docs: update outdated nns-js README #458

merged 4 commits into from
Nov 6, 2023

Conversation

peterpeterparker
Copy link
Member

Motivation

README still shows information and example about the ledger which was moved to a separate lib recently.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 6.79 KB (0%)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger-icrc 2.92 KB (0%)
@dfinity/ledger-icp 14.32 KB (0%)
@dfinity/nns 33.78 KB (0%)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 14.91 KB (0%)
@dfinity/utils 3.81 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

lmuntaner
lmuntaner reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/nns/README.md Outdated Show resolved Hide resolved
@peterpeterparker
Copy link
Member Author

@lmuntaner I think you forgot to click "Approve". Glad I'm not the only one to whom it happens 😂.

lmuntaner
lmuntaner approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry...

@peterpeterparker peterpeterparker merged commit 7874e01 into main Nov 6, 2023
10 checks passed
@peterpeterparker peterpeterparker deleted the docs/nns-readme branch November 6, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @lmuntaner