Rename Topic and NnsFunction values #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
aterga
reviewed
Aug 12, 2024
aterga
approved these changes
Aug 12, 2024
1 task
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Aug 12, 2024
# Motivation Some Topic and NnsFunction enum values in ic-js were renamed in dfinity/ic-js#695 This is a breaking change requiring changes in nns-dapp. # Changes 1. Ran `npm run upgrade:next` 2. Changed enum values to make tests pass. # Tests CI passes # Todos - [ ] Add entry to changelog (if necessary). not necessary
1 task
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Aug 21, 2024
# Motivation Some `nnsFunction` enum keys have been updated in [ic-js](dfinity/ic-js#695), but the corresponding keys in the NNS-dapp governance labels were not updated. This discrepancy leads to missing type field for the renamed types in the NNS-dapp. In this PR, we synchronize the `nnsFunction` label keys to match the `ic-js` enum. # Changes - Rename `UpdateSubnetReplicaVersion` to `DeployGuestosToAllSubnetNodes`. - Rename `UpdateElectedReplicaVersions` to `ReviseElectedGuestosVersions`. - Rename `AddApiBoundaryNode` to `AddApiBoundaryNodes`. - Drive-by: update `getNnsFunctionKey` test name. # Tests - Added a test to verify that there are labels for all provided `nnsFunction` values. - Tested locally to confirm that the `DeployGuestosToAllSubnetNodes` proposal now correctly displays the type field after the changes (which was previously missing). # Todos - [ ] Add entry to changelog (if necessary). Not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some topics and proposal types were renamed in backend enums to better reflect reality.
To avoid confusion, we make the names here consistent with what is used in the backend code.
Changes
TopicandNnsFunctionenums from https://github.com/dfinity/ic/blob/master/rs/nns/governance/proto/ic_nns_governance/pb/v1/governance.protoTests
Prepared changes in nns-dapp to make the tests there pass.
Todos