feat: Remove retries from docker build (#2500)

Author: Bownairo

toolchains/sysimage/build_container_filesystem_tar.py

@@ -6,11 +6,9 @@
 import argparse
 import os
 import shutil
-import sys
-import time
 from dataclasses import dataclass
 from pathlib import Path
-from typing import Callable, List, Optional, TypeVar
+from typing import List, Optional, TypeVar
 
 import invoke
 
@@ -37,27 +35,6 @@ def __post_init__(self):
 ReturnType = TypeVar("ReturnType")  # https://docs.python.org/3/library/typing.html#generics
 
 
-def retry(func: Callable[[], ReturnType], num_retries: int = 3) -> ReturnType:
-    """
-    Call the given `func`. If an exception is raised, print, and retry `num_retries` times.
-    Back off retries by sleeping for at least 5 secs + an exponential increase.
-    Exception is not caught on the last try.
-    """
-    BASE_BACKOFF_WAIT_SECS = 5
-    for i in range(num_retries):
-        try:
-            return func()
-        except Exception as e:
-            print(f"Exception occurred: {e}", file=sys.stderr)
-            print(f"Retries left: {num_retries - i}", file=sys.stderr)
-            wait_time_secs = BASE_BACKOFF_WAIT_SECS + i**2
-            print(f"Waiting for next retry (secs): {wait_time_secs}")
-            time.sleep(wait_time_secs)  # 5, 6, 9, 14, 21, etc.
-
-    # Let the final try actually throw
-    return func()
-
-
 def load_base_image_tar_file(container_cmd: str, tar_file: Path):
     """
     Load the filesystem in the tar file into the podman repo.
@@ -117,10 +94,7 @@ def build_container(
     cmd += f"{context_dir} "
     print(cmd)
 
-    def build_func():
-        invoke.run(cmd)  # Throws on failure
-
-    retry(build_func)
+    invoke.run(cmd)  # Throws on failure
     return image_tag