Skip to content

Commit 971eecc

Browse files
authored
chore(nns): update changelogs (#4793)
This updates changelogs after proposals created today.
1 parent bc47511 commit 971eecc

File tree

7 files changed

+114
-90
lines changed

7 files changed

+114
-90
lines changed

rs/nns/governance/CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,19 @@ here were moved from the adjacent `unreleased_changelog.md` file.
1111
INSERT NEW RELEASES HERE
1212

1313

14+
# 2025-04-11: Proposal 136224
15+
16+
http://dashboard.internetcomputer.org/proposal/136224
17+
18+
## Added
19+
20+
* Governance now gets node provider rewards from the Node Reward Canister in test builds.
21+
22+
## Changed
23+
24+
* The `_pb` methods now always panic.
25+
26+
1427
# 2025-04-05: Proposal 136071
1528

1629
http://dashboard.internetcomputer.org/proposal/136071

rs/nns/governance/unreleased_changelog.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,13 @@ In general, upcoming/unreleased behavior changes are described here. For details
44
on the process that this file is part of, see
55
`rs/nervous_system/changelog_process.md`.
66

7+
78
# Next Upgrade Proposal
89

910
## Added
1011

11-
* Governance now gets node provider rewards from the Node Reward Canister in test builds.
12-
1312
## Changed
1413

15-
* The `_pb` methods now always panic.
16-
1714
## Deprecated
1815

1916
## Removed

rs/node_rewards/canister/CHANGELOG.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,20 @@
1212
INSERT NEW RELEASES HERE
1313

1414

15+
# 2025-04-11: Proposal 136226
16+
17+
http://dashboard.internetcomputer.org/proposal/136226
18+
19+
## Added
20+
21+
* The Node Reward Canister will now perform the calculations that the Registry canister performs for node provider
22+
rewards.
23+
24+
1525
# 2025-04-05: Proposal 136072
1626

1727
http://dashboard.internetcomputer.org/proposal/136072
1828

1929
## Added
2030

2131
* The Node Reward Canister will now sync changes from the Registry canister.
22-

rs/node_rewards/canister/unreleased_changelog.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,11 @@ In general, upcoming/unreleased behavior changes are described here. For details
44
on the process that this file is part of, see
55
`rs/nervous_system/changelog_process.md`.
66

7+
78
# Next Upgrade Proposal
89

910
## Added
1011

11-
* The Node Reward Canister will now perform the calculations that the Registry canister performs for node provider
12-
rewards.
13-
1412
## Changed
1513

1614
## Deprecated

rs/sns/governance/CHANGELOG.md

Lines changed: 88 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,94 @@ here were moved from the adjacent `unreleased_changelog.md` file.
1111
INSERT NEW RELEASES HERE
1212

1313

14+
# 2025-04-11: Proposal 136227
15+
16+
http://dashboard.internetcomputer.org/proposal/136227
17+
18+
## Added
19+
20+
### Topic-based following
21+
22+
The new `SetFollowing` neuron command allows following voting decisions based on proposal topics.
23+
24+
This command can be used to set or change following for any number of topics at once. Users
25+
are encouraged to set following based on topics, although _legacy following_ (based on
26+
individual proposal types) will still work until further notice. However, this command may clear
27+
some legacy following if it becomes redundant, specifically, in the following cases:
28+
29+
1. Following on proposal types within the topics explicitly mentioned by `SetFollowing`.
30+
2. Legacy catch-all following, if a neuron has topic-based following for all non-critical
31+
topics, or if the `SetFollowing` command mentions each non-critical topic.
32+
33+
For example:
34+
35+
```bash
36+
dfx canister --ic call SNS_GOVERNANCE manage_neuron '(record {
37+
subaccount = FOLLOWER_NEURON_ID_BLOB;
38+
command = opt variant {
39+
SetFollowing = record {
40+
topic_following = vec {
41+
record {
42+
topic = opt variant { ApplicationBusinessLogic };
43+
followees = vec {
44+
record {
45+
alias = opt "Giuseppe Arcimboldo";
46+
neuron_id = opt record { id = FOLLOWEE_NEURON_ID_BLOB };
47+
};
48+
};
49+
};
50+
record {
51+
topic = opt variant { CriticalDappOperations };
52+
followees = vec {};
53+
}}}}})'
54+
```
55+
56+
In this example, following on the `ApplicationBusinessLogic` topic is changed (from whatever has
57+
been there before) to a single neuron, and following on `CriticalDappOperations` is being
58+
removed.
59+
60+
Followee _aliases_ are option; they are currently used only when listing neurons being followed
61+
(a.k.a. followees), which helps remember why a particular one has been added in the first place.
62+
63+
**Backward compatibility.**
64+
Legacy following still works for proposal types and for neurons that do not have any topic-based
65+
following for covering that proposal type. For example, after executing the following command,
66+
the modified neuron would still follow on, e.g., `DeregisterDappCanisters` proposals, assuming
67+
it had followed some neuron on this proposal type.
68+
69+
Topic-based following takes precedence over legacy following, e.g., regardless of which
70+
legacy following has been set up for the neuron modified in the above example, that neuron will
71+
now only follow Giuseppe Arcimboldo on proposals within the `ApplicationBusinessLogic` topic.
72+
73+
Legacy _catch-all_ following is also still supported for neurons that follow on the respective
74+
special proposal type `0`, but only for neurons that do not already follow on the specific topic
75+
in question (nor follow on the specific proposal type being voted on). In other words, catch-all
76+
has the lowest precedence, and topic-based following now has the highest.
77+
78+
### Filtering proposals by topic
79+
80+
`SnsGov.list_proposals` now supports filtering by proposal topic. For example, the following
81+
command can be used to list proposals that are either under the `Governance` topic or do not specify
82+
a topic:
83+
84+
```sh
85+
dfx canister SNS_GOVERNANCE call list_proposals '(
86+
record {
87+
include_reward_status = vec {};
88+
limit = 0 : nat32;
89+
exclude_type = vec {};
90+
include_status = vec {};
91+
include_topic = opt vec {
92+
record { topic = null };
93+
record { topic = opt variant { Governance } };
94+
};
95+
},
96+
)'
97+
```
98+
99+
If `include_topic` is not mentioned or `null`, then proposals are listed regardless of their topic.
100+
101+
14102
# 2025-03-21: Proposal 135935
15103

16104
http://dashboard.internetcomputer.org/proposal/135935

rs/sns/governance/unreleased_changelog.md

Lines changed: 0 additions & 81 deletions
Original file line numberDiff line numberDiff line change
@@ -9,87 +9,6 @@ on the process that this file is part of, see
99

1010
## Added
1111

12-
### Topic-based following
13-
14-
The new `SetFollowing` neuron command allows following voting decisions based on proposal topics.
15-
16-
This command can be used to set or change following for any number of topics at once. Users
17-
are encouraged to set following based on topics, although _legacy following_ (based on
18-
individual proposal types) will still work until further notice. However, this command may clear
19-
some legacy following if it becomes redundant, specifically, in the following cases:
20-
21-
1. Following on proposal types within the topics explicitly mentioned by `SetFollowing`.
22-
2. Legacy catch-all following, if a neuron has topic-based following for all non-critical
23-
topics, or if the `SetFollowing` command mentions each non-critical topic.
24-
25-
For example:
26-
27-
```bash
28-
dfx canister --ic call SNS_GOVERNANCE manage_neuron '(record {
29-
subaccount = FOLLOWER_NEURON_ID_BLOB;
30-
command = opt variant {
31-
SetFollowing = record {
32-
topic_following = vec {
33-
record {
34-
topic = opt variant { ApplicationBusinessLogic };
35-
followees = vec {
36-
record {
37-
alias = opt "Giuseppe Arcimboldo";
38-
neuron_id = opt record { id = FOLLOWEE_NEURON_ID_BLOB };
39-
};
40-
};
41-
};
42-
record {
43-
topic = opt variant { CriticalDappOperations };
44-
followees = vec {};
45-
}}}}})'
46-
```
47-
48-
In this example, following on the `ApplicationBusinessLogic` topic is changed (from whatever has
49-
been there before) to a single neuron, and following on `CriticalDappOperations` is being
50-
removed.
51-
52-
Followee _aliases_ are option; they are currently used only when listing neurons being followed
53-
(a.k.a. followees), which helps remember why a particular one has been added in the first place.
54-
55-
**Backward compatibility.**
56-
Legacy following still works for proposal types and for neurons that do not have any topic-based
57-
following for covering that proposal type. For example, after executing the following command,
58-
the modified neuron would still follow on, e.g., `DeregisterDappCanisters` proposals, assuming
59-
it had followed some neuron on this proposal type.
60-
61-
Topic-based following takes precedence over legacy following, e.g., regardless of which
62-
legacy following has been set up for the neuron modified in the above example, that neuron will
63-
now only follow Giuseppe Arcimboldo on proposals within the `ApplicationBusinessLogic` topic.
64-
65-
Legacy _catch-all_ following is also still supported for neurons that follow on the respective
66-
special proposal type `0`, but only for neurons that do not already follow on the specific topic
67-
in question (nor follow on the specific proposal type being voted on). In other words, catch-all
68-
has the lowest precedence, and topic-based following now has the highest.
69-
70-
### Filtering proposals by topic
71-
72-
`SnsGov.list_proposals` now supports filtering by proposal topic. For example, the following
73-
command can be used to list proposals that are either under the `Governance` topic or do not specify
74-
a topic:
75-
76-
```sh
77-
dfx canister SNS_GOVERNANCE call list_proposals '(
78-
record {
79-
include_reward_status = vec {};
80-
limit = 0 : nat32;
81-
exclude_type = vec {};
82-
include_status = vec {};
83-
include_topic = opt vec {
84-
record { topic = null };
85-
record { topic = opt variant { Governance } };
86-
};
87-
},
88-
)'
89-
```
90-
91-
If `include_topic` is not mentioned or `null`, then proposals are listed regardless of their topic.
92-
9312
## Changed
9413

9514
## Deprecated

testnet/tools/nns-tools/add-release-to-changelog.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ else
7575
print_red "(In particular, unable to determine which canister and commit.)" >&2
7676
exit 1
7777
fi
78-
SECONDS_AGO=$(($(gdate +%s) - "${PROPOSED_TIMESTAMP_SECONDS}"))
78+
SECONDS_AGO=$(($(gdate +%s) - ${PROPOSED_TIMESTAMP_SECONDS}))
7979
PROPOSED_ON=$(
8080
gdate --utc \
8181
--date=@"${PROPOSED_TIMESTAMP_SECONDS}" \

0 commit comments

Comments
 (0)