Skip to content

Commit aa0c00c

Browse files
authored
test: Fix registry tests (#6009)
The test was erroneously querying `ReplicaVersion::default()` instead of `version_43` and passed because we reused the same `MOCK_HASH` value in multiple places. This PR fixes the test and replaces `MOCK_HASH` with different values in different files.
1 parent 21ee6eb commit aa0c00c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

rs/nns/test_utils/src/registry.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ pub fn invariant_compliant_mutation_with_subnet_id(
353353
..Default::default()
354354
}
355355
};
356-
const MOCK_HASH: &str = "d1bc8d3ba4afc7e109612cb73acbdddac052c93025aa1f82942edabb7deb82a1";
356+
const MOCK_HASH: &str = "deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef";
357357
let release_package_url = "http://release_package.tar.zst".to_string();
358358
let replica_version_id = ReplicaVersion::default().to_string();
359359
let replica_version = ReplicaVersionRecord {
@@ -617,7 +617,7 @@ pub fn initial_mutations_for_a_multinode_nns_subnet() -> Vec<RegistryMutation> {
617617
}
618618

619619
let replica_version_id = ReplicaVersion::default().to_string();
620-
const MOCK_HASH: &str = "d1bc8d3ba4afc7e109612cb73acbdddac052c93025aa1f82942edabb7deb82a1";
620+
const MOCK_HASH: &str = "abbaabbaabbaabbaabbaabbaabbaabbaabbaabbaabbaabbaabbaabbaabbaabba";
621621
let release_package_url = "http://release_package.tar.zst".to_string();
622622
let replica_version = ReplicaVersionRecord {
623623
release_package_sha256_hex: MOCK_HASH.into(),

rs/registry/canister/tests/update_subnet_and_bless_replica_version.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ use registry_canister::{
2727
},
2828
};
2929

30-
const MOCK_HASH: &str = "d1bc8d3ba4afc7e109612cb73acbdddac052c93025aa1f82942edabb7deb82a1";
30+
const MOCK_HASH: &str = "acdcacdcacdcacdcacdcacdcacdcacdcacdcacdcacdcacdcacdcacdcacdcacdc";
3131

3232
#[test]
3333
fn test_the_anonymous_user_cannot_elect_a_version() {
@@ -219,7 +219,7 @@ fn test_accepted_proposal_mutates_the_registry() {
219219
assert_eq!(
220220
get_value_or_panic::<ReplicaVersionRecord>(
221221
&registry,
222-
make_replica_version_key(ReplicaVersion::default()).as_bytes()
222+
make_replica_version_key("version_43").as_bytes()
223223
)
224224
.await,
225225
ReplicaVersionRecord {

0 commit comments

Comments
 (0)