feat: enable allowed_viewers feature for canister log visibility (#2244)

maksymar · web-flow · commit b29e83ac7c4a · 2024-10-24T14:01:44.000Z
This PR enables `allowed_viewers` for canister log visibility. EXC-1697
diff --git a/rs/config/src/execution_environment.rs b/rs/config/src/execution_environment.rs
@@ -360,7 +360,7 @@ impl Default for Config {
             dirty_page_logging: FlagStatus::Disabled,
             max_canister_http_requests_in_flight: MAX_CANISTER_HTTP_REQUESTS_IN_FLIGHT,
             default_wasm_memory_limit: DEFAULT_WASM_MEMORY_LIMIT,
-            allowed_viewers_feature: FlagStatus::Disabled,
+            allowed_viewers_feature: FlagStatus::Enabled,
         }
     }
 }
diff --git a/rs/execution_environment/tests/canister_logging.rs b/rs/execution_environment/tests/canister_logging.rs
@@ -280,8 +280,7 @@ fn test_log_visibility_of_fetch_canister_logs() {
         (
             LogVisibilityV2::AllowedViewers(allowed_viewers.clone()),
             allowed_viewer,
-            // TODO(EXC-1675): when disabled works as for controllers, change to ok when enabled.
-            not_allowed_error(&allowed_viewer),
+            ok.clone(),
         ),
         (
             LogVisibilityV2::AllowedViewers(allowed_viewers.clone()),

Original file line number	Diff line number	Diff line change
`@@ -360,7 +360,7 @@ impl Default for Config {`
`360`	`360`	`dirty_page_logging: FlagStatus::Disabled,`
`361`	`361`	`max_canister_http_requests_in_flight: MAX_CANISTER_HTTP_REQUESTS_IN_FLIGHT,`
`362`	`362`	`default_wasm_memory_limit: DEFAULT_WASM_MEMORY_LIMIT,`
`363`		`- allowed_viewers_feature: FlagStatus::Disabled,`
	`363`	`+ allowed_viewers_feature: FlagStatus::Enabled,`
`364`	`364`	`}`
`365`	`365`	`}`
`366`	`366`	`}`
Original file line number	Diff line number	Diff line change
`@@ -280,8 +280,7 @@ fn test_log_visibility_of_fetch_canister_logs() {`
`280`	`280`	`(`
`281`	`281`	`LogVisibilityV2::AllowedViewers(allowed_viewers.clone()),`
`282`	`282`	`allowed_viewer,`
`283`		`- // TODO(EXC-1675): when disabled works as for controllers, change to ok when enabled.`
`284`		`- not_allowed_error(&allowed_viewer),`
	`283`	`+ ok.clone(),`
`285`	`284`	`),`
`286`	`285`	`(`
`287`	`286`	`LogVisibilityV2::AllowedViewers(allowed_viewers.clone()),`