chore: remove unneeded clippy allows (#2326)

Author: rumenov

clippy.toml

@@ -1,4 +1,6 @@
 too-many-arguments-threshold = 12
+allow-expect-in-tests = true
+allow-unwrap-in-tests = true
 disallowed-methods = [
     { path = "bincode::deserialize_from", reason = "bincode::deserialize_from() is not safe to use on untrusted data, since the method will read a u64 length value from the first 8 bytes of the serialized payload and will then attempt to allocate this number of bytes without any validation." },
     { path = "std::io::Write::write", reason = "`Write::write()` may not write the entire buffer. Use `Write::write_all()` instead. Or, if you are intentionally using `Write::write()`, use `#[allow(clippy::disallowed_methods)]` to locally disable this check." },

rs/artifact_pool/src/inmemory_pool.rs

@@ -179,7 +179,6 @@ where
 
         // returning the iterator directly isn't trusted due to the use of `self` in the
         // closure
-        #[allow(clippy::needless_collect)]
         let vec: Vec<T> = heights.flat_map(|h| self.get_by_height(*h)).collect();
         Box::new(vec.into_iter())
     }

rs/bitcoin/ckbtc/minter/src/guard.rs

@@ -166,7 +166,6 @@ mod tests {
     }
 
     #[test]
-    #[allow(clippy::needless_collect)]
     fn guard_prevents_more_than_max_concurrent_principals() {
         // test that at most MAX_CONCURRENT guards can be created if each one
         // is for a different principal

rs/crypto/internal/crypto_lib/basic_sig/der_utils/src/tests.rs

@@ -1,4 +1,3 @@
-#![allow(clippy::unwrap_used)]
 use super::*;
 use simple_asn1::oid;
 

rs/crypto/internal/crypto_lib/basic_sig/ecdsa_secp256k1/tests/api_tests.rs

@@ -1,5 +1,3 @@
-#![allow(clippy::unwrap_used)]
-
 use ic_crypto_internal_basic_sig_ecdsa_secp256k1::{types, *};
 
 // SECP256K1_PK_1_DER_HEX was generated via the following commands:

rs/crypto/internal/crypto_lib/basic_sig/ed25519/src/api/tests.rs

@@ -1,5 +1,3 @@
-#![allow(clippy::unwrap_used)]
-
 mod keygen {
     use crate::keypair_from_rng;
     use ic_crypto_internal_test_vectors::unhex::hex_to_32_bytes;

rs/crypto/internal/crypto_lib/basic_sig/ed25519/src/types/conversions/protobuf/tests.rs

@@ -1,4 +1,3 @@
-#![allow(clippy::unwrap_used)]
 use super::*;
 
 #[test]

rs/crypto/internal/crypto_lib/basic_sig/iccsa/src/types/conversions/tests.rs

@@ -1,4 +1,3 @@
-#![allow(clippy::unwrap_used)]
 use crate::types::conversions::PublicKeyFromBytesError;
 use crate::types::PublicKey;
 use crate::types::PublicKeyBytes;

rs/crypto/internal/crypto_lib/basic_sig/iccsa/tests/api.rs

@@ -1,4 +1,3 @@
-#![allow(clippy::unwrap_used)]
 use assert_matches::assert_matches;
 use ic_certification_test_utils::serialize_to_cbor;
 use ic_crypto_internal_basic_sig_iccsa::types::*;

rs/crypto/internal/crypto_lib/multi_sig/bls12_381/src/tests.rs

@@ -1,5 +1,3 @@
-#![allow(clippy::unwrap_used)]
-
 //! Tests for multisignatures
 
 use crate::{