fix(consensus_manager): Do not discard download time metric and add send on reconnection metric

Author: tthebst

rs/p2p/consensus_manager/src/metrics.rs

@@ -41,6 +41,7 @@ pub(crate) struct ConsensusManagerMetrics {
     pub send_view_consensus_dup_purge_total: IntCounter,
     pub send_view_send_to_peer_total: IntCounter,
     pub send_view_send_to_peer_delivered_total: IntCounter,
+    pub send_view_resend_reconnect_total: IntCounter,
 
     // Slot manager
     pub slot_manager_used_slots: IntGauge,
@@ -240,6 +241,14 @@ impl ConsensusManagerMetrics {
                 ))
                 .unwrap(),
             ),
+            send_view_resend_reconnect_total: metrics_registry.register(
+                IntCounter::with_opts(opts!(
+                    "ic_consensus_manager_send_view_resend_reconnect_total",
+                    "Artifact was sent again due to reconnection.",
+                    const_labels.clone(),
+                ))
+                .unwrap(),
+            ),
 
             slot_manager_used_slots: metrics_registry.register(
                 IntGauge::with_opts(opts!(

rs/p2p/consensus_manager/src/receiver.rs

@@ -561,7 +561,7 @@ where
                     .await?;
                 }
 
-                timer.stop_and_discard();
+                timer.stop_and_record();
 
                 result
             }

rs/p2p/consensus_manager/src/sender.rs

@@ -204,7 +204,15 @@ impl<Artifact: ArtifactKind> ConsensusManagerSender<Artifact> {
                     // spawn task for peers with higher conn id or not in completed transmissions.
                     // add task to join map
                     for (peer, connection_id) in transport.peers() {
-                        let is_initiated = initiated_transmissions.get(&peer).is_some_and(|c| *c == connection_id);
+                        let is_initiated = initiated_transmissions.get(&peer).is_some_and(|c| {
+                            if *c == connection_id {
+                                true
+                            } else {
+                                metrics.send_view_resend_reconnect_total.inc();
+                                false
+                            }
+                        });
+
 
                         if !is_initiated {
                             metrics.send_view_send_to_peer_total.inc();