chore: Remove deprecated EcdsaConfig (#5899)

These types are no longer in use since they were superseded by the
`ChainKeyConfig`.

Author: eichhorl

rs/protobuf/def/registry/subnet/v1/subnet.proto

@@ -301,24 +301,6 @@ message SubnetFeatures {
   optional bool sev_enabled = 9;
 }
 
-// Per subnet ECDSA configuration
-//
-// Deprecated; please use ChainKeyConfig instead.
-message EcdsaConfig {
-  // Number of quadruples to create in advance.
-  uint32 quadruples_to_create_in_advance = 1;
-  reserved 2;
-  // Identifiers for threshold ECDSA keys held by the subnet.
-  repeated types.v1.EcdsaKeyId key_ids = 3;
-  // The maximum number of signature requests that can be enqueued at once.
-  uint32 max_queue_size = 4;
-  // Signature requests will timeout after the given number of nano seconds.
-  optional uint64 signature_request_timeout_ns = 5;
-  // Key rotation period of a single node in milliseconds.
-  // If none is specified key rotation is disabled.
-  optional uint64 idkg_key_rotation_period_ms = 6;
-}
-
 message KeyConfig {
   // The key's identifier.
   optional types.v1.MasterPublicKeyId key_id = 1;

rs/protobuf/generator/src/lib.rs

@@ -213,10 +213,6 @@ fn build_registry_proto(def: &Path, out: &Path) {
         ".registry.subnet",
         "#[derive(serde::Serialize, serde::Deserialize)]",
     );
-    config.type_attribute(
-        ".registry.subnet.v1.EcdsaConfig",
-        "#[derive(candid::CandidType, Eq)]",
-    );
     config.type_attribute(
         ".registry.subnet.v1.SubnetFeatures",
         "#[derive(candid::CandidType, Eq)]",

rs/protobuf/src/gen/registry/registry.subnet.v1.rs

@@ -311,30 +311,6 @@ pub struct SubnetFeatures {
     #[prost(bool, optional, tag = "9")]
     pub sev_enabled: ::core::option::Option<bool>,
 }
-/// Per subnet ECDSA configuration
-///
-/// Deprecated; please use ChainKeyConfig instead.
-#[derive(
-    serde::Serialize, serde::Deserialize, candid::CandidType, Eq, Clone, PartialEq, ::prost::Message,
-)]
-pub struct EcdsaConfig {
-    /// Number of quadruples to create in advance.
-    #[prost(uint32, tag = "1")]
-    pub quadruples_to_create_in_advance: u32,
-    /// Identifiers for threshold ECDSA keys held by the subnet.
-    #[prost(message, repeated, tag = "3")]
-    pub key_ids: ::prost::alloc::vec::Vec<super::super::super::types::v1::EcdsaKeyId>,
-    /// The maximum number of signature requests that can be enqueued at once.
-    #[prost(uint32, tag = "4")]
-    pub max_queue_size: u32,
-    /// Signature requests will timeout after the given number of nano seconds.
-    #[prost(uint64, optional, tag = "5")]
-    pub signature_request_timeout_ns: ::core::option::Option<u64>,
-    /// Key rotation period of a single node in milliseconds.
-    /// If none is specified key rotation is disabled.
-    #[prost(uint64, optional, tag = "6")]
-    pub idkg_key_rotation_period_ms: ::core::option::Option<u64>,
-}
 #[derive(serde::Serialize, serde::Deserialize, Clone, PartialEq, ::prost::Message)]
 pub struct KeyConfig {
     /// The key's identifier.

rs/protobuf/src/gen/state/registry.subnet.v1.rs

@@ -302,28 +302,6 @@ pub struct SubnetFeatures {
     #[prost(bool, optional, tag = "9")]
     pub sev_enabled: ::core::option::Option<bool>,
 }
-/// Per subnet ECDSA configuration
-///
-/// Deprecated; please use ChainKeyConfig instead.
-#[derive(Clone, PartialEq, ::prost::Message)]
-pub struct EcdsaConfig {
-    /// Number of quadruples to create in advance.
-    #[prost(uint32, tag = "1")]
-    pub quadruples_to_create_in_advance: u32,
-    /// Identifiers for threshold ECDSA keys held by the subnet.
-    #[prost(message, repeated, tag = "3")]
-    pub key_ids: ::prost::alloc::vec::Vec<super::super::super::types::v1::EcdsaKeyId>,
-    /// The maximum number of signature requests that can be enqueued at once.
-    #[prost(uint32, tag = "4")]
-    pub max_queue_size: u32,
-    /// Signature requests will timeout after the given number of nano seconds.
-    #[prost(uint64, optional, tag = "5")]
-    pub signature_request_timeout_ns: ::core::option::Option<u64>,
-    /// Key rotation period of a single node in milliseconds.
-    /// If none is specified key rotation is disabled.
-    #[prost(uint64, optional, tag = "6")]
-    pub idkg_key_rotation_period_ms: ::core::option::Option<u64>,
-}
 #[derive(Clone, PartialEq, ::prost::Message)]
 pub struct KeyConfig {
     /// The key's identifier.

rs/protobuf/src/gen/types/registry.subnet.v1.rs

@@ -302,28 +302,6 @@ pub struct SubnetFeatures {
     #[prost(bool, optional, tag = "9")]
     pub sev_enabled: ::core::option::Option<bool>,
 }
-/// Per subnet ECDSA configuration
-///
-/// Deprecated; please use ChainKeyConfig instead.
-#[derive(Clone, PartialEq, ::prost::Message)]
-pub struct EcdsaConfig {
-    /// Number of quadruples to create in advance.
-    #[prost(uint32, tag = "1")]
-    pub quadruples_to_create_in_advance: u32,
-    /// Identifiers for threshold ECDSA keys held by the subnet.
-    #[prost(message, repeated, tag = "3")]
-    pub key_ids: ::prost::alloc::vec::Vec<super::super::super::types::v1::EcdsaKeyId>,
-    /// The maximum number of signature requests that can be enqueued at once.
-    #[prost(uint32, tag = "4")]
-    pub max_queue_size: u32,
-    /// Signature requests will timeout after the given number of nano seconds.
-    #[prost(uint64, optional, tag = "5")]
-    pub signature_request_timeout_ns: ::core::option::Option<u64>,
-    /// Key rotation period of a single node in milliseconds.
-    /// If none is specified key rotation is disabled.
-    #[prost(uint64, optional, tag = "6")]
-    pub idkg_key_rotation_period_ms: ::core::option::Option<u64>,
-}
 #[derive(Clone, PartialEq, ::prost::Message)]
 pub struct KeyConfig {
     /// The key's identifier.

rs/registry/canister/canister/registry.did

@@ -159,14 +159,6 @@ type VetKdKeyId = record { curve: VetKdCurve; name: text };
 
 type VetKdCurve = variant { bls12_381_g2 };
 
-type EcdsaConfig = record {
-  quadruples_to_create_in_advance : nat32;
-  max_queue_size : opt nat32;
-  key_ids : vec EcdsaKeyId;
-  signature_request_timeout_ns : opt nat64;
-  idkg_key_rotation_period_ms : opt nat64;
-};
-
 type EcdsaCurve = variant { secp256k1 };
 
 type EcdsaInitialConfig = record {

rs/registry/canister/canister/registry_test.did

@@ -159,14 +159,6 @@ type VetKdKeyId = record { curve: VetKdCurve; name: text };
 
 type VetKdCurve = variant { bls12_381_g2 };
 
-type EcdsaConfig = record {
-  quadruples_to_create_in_advance : nat32;
-  max_queue_size : opt nat32;
-  key_ids : vec EcdsaKeyId;
-  signature_request_timeout_ns : opt nat64;
-  idkg_key_rotation_period_ms : opt nat64;
-};
-
 type EcdsaCurve = variant { secp256k1 };
 
 type EcdsaInitialConfig = record {

rs/registry/subnet_features/src/lib.rs

@@ -1,5 +1,5 @@
 use candid::CandidType;
-use ic_management_canister_types_private::{EcdsaKeyId, MasterPublicKeyId};
+use ic_management_canister_types_private::MasterPublicKeyId;
 use ic_protobuf::types::v1 as pb_types;
 use ic_protobuf::{
     proxy::{try_from_option_field, ProxyDecodeError},
@@ -88,15 +88,6 @@ impl FromStr for SubnetFeatures {
     }
 }
 
-#[derive(Clone, Eq, PartialEq, Debug, Default, CandidType, Deserialize, Serialize)]
-pub struct EcdsaConfig {
-    pub quadruples_to_create_in_advance: u32,
-    pub key_ids: Vec<EcdsaKeyId>,
-    pub max_queue_size: Option<u32>,
-    pub signature_request_timeout_ns: Option<u64>,
-    pub idkg_key_rotation_period_ms: Option<u64>,
-}
-
 #[derive(Clone, Eq, PartialEq, Debug, CandidType, Deserialize, Serialize)]
 pub struct KeyConfig {
     pub key_id: MasterPublicKeyId,
@@ -194,7 +185,7 @@ impl TryFrom<pb::ChainKeyConfig> for ChainKeyConfig {
 
 #[cfg(test)]
 mod tests {
-    use ic_management_canister_types_private::{EcdsaCurve, VetKdCurve, VetKdKeyId};
+    use ic_management_canister_types_private::{EcdsaCurve, EcdsaKeyId, VetKdCurve, VetKdKeyId};
 
     use super::*;
     use std::str::FromStr;