Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-1360): Configuration revamp (SetupOS integration) #1190

Closed
wants to merge 198 commits into from
Closed

feat(NODE-1360): Configuration revamp (SetupOS integration) #1190

wants to merge 198 commits into from

Conversation

andrewbattat
Copy link
Member

@andrewbattat andrewbattat commented Aug 28, 2024 •
edited
Loading

NODE-1360

Once we’re happy with the new version of the config pipeline, we’ll worry about the rollout and the backwards compatibility

High level overview:

SetupOS:

  • Config struct build via config.service (written to disk as config.json)
  • all access to config done through config struct (bash scripts + rust network config updated)
  • config struct transformed to a hostos config struct and (commented out: written to HostOS config)

HostOS/GuestOS:

  • No functional changes yet

Bare metal test: ✅
Hourly test: ✅ (https://github.com/dfinity/ic/actions/runs/10892794134)

@andrewbattat andrewbattat self-assigned this Aug 28, 2024
@andrewbattat andrewbattat changed the title Configuration revamp feat(NODE-1360): Configuration revamp Aug 28, 2024
@github-actions github-actions bot added the feat label Aug 28, 2024
@andrewbattat
Add cpu_mode field to deployment.json
fe8772e
@andrewbattat
Create constructors
5311b65
@andrewbattat
Fix deployment.rs and naming
4e181bb
@andrewbattat
Add new standard deployment test
6e3ca3f
@andrewbattat
Update DeserializeOwned using serde_json::from_value test to standard
941edab
@andrewbattat
Fix indentation
3fcc4a1
@andrewbattat
Add cpu_mode field to deployment.json
849c061
@andrewbattat
Cargo fmt
6af0798
@andrewbattat
Revert name back to cpu
c885196
@andrewbattat
Update call to cpu
253042c
@andrewbattat
cpu mode updates
5d766db
@andrewbattat
Parse setupOS inputs and almost create object
795dd10
@andrewbattat
Move todo comment
9d39019
@andrewbattat
Clean up types
f1bd383
@andrewbattat
Nearly constructing SetupOS config object
06cab7b
@andrewbattat
Add expected value comment for cpu
c005309
@andrewbattat
Break up hosts strings into list
d11c883
@andrewbattat
cargo fmt
d02bf02
@andrewbattat
Complete basic setupOS config parsing
9aa4aca
@andrewbattat
Allow deadcode and fix comments
dadb94a
@andrewbattat
Add doc comment within setupos-inject-configuration
e80891c
@andrewbattat
Update parse_config_ini_networking name
5eaad1b
@andrewbattat
Create separate default_deployment_values func
0ab0d97
@andrewbattat
Update elasticsearch to list concatenation
ef608a5
@andrewbattat
Refactoring
8744d8e
@andrewbattat andrewbattat removed request for a team September 18, 2024 18:46
levifeldman pushed a commit to levifeldman/ic that referenced this pull request Oct 1, 2024
@andrewbattat @levifeldman
feat(NODE-1475): Configuration revamp (define config structure and co…
abd4525 
…nfig tool) (dfinity#1539)

[NODE-1360](https://dfinity.atlassian.net/browse/NODE-1360)

Changes pulled out of: dfinity#1190

This PR defines the config structure and config tool, but does not yet
integrate the config tool into SetupOS. This PR should not have an
impact on the ic-os. Later, the config tool will be utilized for config
sanitization, organization, access, and propagation.

[NODE-1360]:
https://dfinity.atlassian.net/browse/NODE-1360?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DFINITYManu DFINITYManu DFINITYManu left review comments

@Bownairo Bownairo Bownairo left review comments

@frankdavid frankdavid frankdavid approved these changes

@joeodfinity joeodfinity joeodfinity approved these changes

Assignees

@andrewbattat andrewbattat

Labels
feat @node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewbattat @frankdavid @Bownairo @joeodfinity @DFINITYManu