refactor(nns): Some refactoring on how neuron subaccount addresses are calculated #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonz-dfinity
force-pushed
the
jason/NNS1-3253
branch
from
761bd8a
to
e67569a
Compare
max-dfinity
approved these changes
Sep 5, 2024
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
…e calculated (dfinity#1317) # Why The logic and documentation around NNS neuron subaccount addresses are confusing. # What * Update the link to dfinity_wallet to ic-js. * Refactor the calculation logic for different neuron subaccounts to using the same function. * Move the pointer to the ic-js link to a new test for the staking account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The logic and documentation around NNS neuron subaccount addresses are confusing.
What