Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade the xnet endpoint to hyper >1 #1360

Merged
merged 11 commits into from
Sep 6, 2024

Conversation

rumenov
Copy link
Member

@rumenov rumenov commented Sep 5, 2024

Use the same tokio runtime for all http servers

I have ran ict test //rs/tests/message_routing/xnet:xnet_slo_120_subnets_staging_test multiple times and it always passed

@rumenov rumenov changed the title Rumenov/xnet endpoint upgrade chore: upgrade the xnet endpoint to hyper >1 Sep 6, 2024
@github-actions github-actions bot added the chore label Sep 6, 2024
@rumenov rumenov marked this pull request as ready for review September 6, 2024 09:29
@rumenov rumenov requested review from a team as code owners September 6, 2024 09:29
@stedfn
Copy link
Contributor

stedfn commented Sep 6, 2024

I still got some timeouts on this branch. However, less than before

@rumenov
Copy link
Member Author

rumenov commented Sep 6, 2024

I still got some timeouts on this branch. However, less than before

@stedfn Can you fork this branch and add the spawn_blocking in the client and see if things are better.

@rumenov rumenov added this pull request to the merge queue Sep 6, 2024
Merged via the queue into master with commit 5d25ae6 Sep 6, 2024
35 of 36 checks passed
@rumenov rumenov deleted the rumenov/xnet_endpoint_upgrade branch September 6, 2024 14:44
@stedfn
Copy link
Contributor

stedfn commented Sep 8, 2024

@rumenov I still see timeouts with the spawn_blocking added

levifeldman pushed a commit to levifeldman/ic that referenced this pull request Oct 1, 2024
Use the same tokio runtime for all http servers

I have ran `ict test
//rs/tests/message_routing/xnet:xnet_slo_120_subnets_staging_test`
multiple times and it always passed

---------

Co-authored-by: Stefan Neamtu <stefan.neamtu@gmail.com>
Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants