refactor(nns): Eliminate ExecutedCreateServiceNervousSystemProposal
#1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-dfinity
reviewed
Sep 5, 2024
max-dfinity
approved these changes
Sep 5, 2024
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
…dfinity#1366) This PR refactors the code in NNS Governance responsible for executing `CreateServiceNervousSystem` proposals s.t. it no longer requires the internal type `ExecutedCreateServiceNervousSystemProposal`. This type was intended to be internal but has become public for CLI tools to validate instances of this proposal type, which adds an undesirable crate-level dependency between, e.g., `//rs/nns/governance` and `//rs/sns/init`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the code in NNS Governance responsible for executing
CreateServiceNervousSystemproposals s.t. it no longer requires the internal typeExecutedCreateServiceNervousSystemProposal. This type was intended to be internal but has become public for CLI tools to validate instances of this proposal type, which adds an undesirable crate-level dependency between, e.g.,//rs/nns/governanceand//rs/sns/init.