feat: [MR-607] Ignore non-matching best-effort responses #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A best-effort response may be inducted after the matching call context has already expired; the reject response has been executed; and the call context was dropped. Because of this (and as opposed to guaranteed responses, where a duplicate or non-matching callback implies malicious behavior or a bug) best-effort responses that are either duplicates or don't match an exosting callback should be silently dropped.
alin-at-dfinity
requested review from
stiegerc,
derlerd-dfinity and
oggy-dfin
alin-at-dfinity
changed the title
derlerd-dfinity
approved these changes
Sep 18, 2024
alin-at-dfinity
deleted the
alin/MR-607-mismatching-best-effort-responses
branch
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
A best-effort response may be inducted after the matching call context has already expired; the reject response has been executed; and the call context was dropped. Because of this (and as opposed to guaranteed responses, where a duplicate or non-matching callback implies malicious behavior or a bug) best-effort responses that are either duplicates or don't match an existing callback should be silently dropped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A best-effort response may be inducted after the matching call context has already expired; the reject response has been executed; and the call context was dropped. Because of this (and as opposed to guaranteed responses, where a duplicate or non-matching callback implies malicious behavior or a bug) best-effort responses that are either duplicates or don't match an existing callback should be silently dropped.