chore(PocketIC): clean up PocketIC builder patterns #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-weigelt
approved these changes
Sep 24, 2024
frankdavid
pushed a commit
that referenced
this pull request
Sep 25, 2024
This PR cleans up the PocketIC builder patterns by adding a function `PocketIcBuilder::new_with_config` to specify a custom `ExtendedSubnetConfigSet` and removing functions `PocketIc::from_config`, `PocketIc::from_config_and_max_request_time`, and `PocketIc::from_config_and_server_url` that can be expressed via the `PocketIcBuilder`.
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
This PR cleans up the PocketIC builder patterns by adding a function `PocketIcBuilder::new_with_config` to specify a custom `ExtendedSubnetConfigSet` and removing functions `PocketIc::from_config`, `PocketIc::from_config_and_max_request_time`, and `PocketIc::from_config_and_server_url` that can be expressed via the `PocketIcBuilder`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the PocketIC builder patterns by adding a function
PocketIcBuilder::new_with_configto specify a customExtendedSubnetConfigSetand removing functionsPocketIc::from_config,PocketIc::from_config_and_max_request_time, andPocketIc::from_config_and_server_urlthat can be expressed via thePocketIcBuilder.